very nice one, amazing results at the first glance

i will be watching your site for sure!. Didn’t look at your other strategies yet. I adjusted your system posted here. Instead of using fixed scaleinpoints and scaleoutpoints you could also use the ATR function to determine the points to use. This is what I did and works good even with a slippage of 2 ticks

ah, an error found.

the buyprice is redefined using BuyPrice=ValueWhen(Buy,C);

you may use: BuyPrice=ValueWhen(Buy,C);

but then later you have to use

BuyPrice=Open;
SellPrice=Open;
ShortPrice=Open;
CoverPrice=Open;

so rather than setting these prices at the start of the code you need to set them after

Buy = Buy + sigScaleIn * DoScaleIn + sigScaleOut * DoScaleOut;

intuitively I already thought it makes no sense since if it would work then a simple MACD system would also work, which it does not. Now what you do is scale in at prices of your initial buy price, and that is incorrect

or part of your code needs to be corrected to:

iBuyPrice=ValueWhen(Buy,C);
 
for( i = 1; i < BarCount; i++ ) { Profit[i]=Close[i]-iBuyPrice[i]>=ScaleInPoints;
    Loss[i]=Close[i]-iBuyPrice[i]<=-ScaleOutPoints;
    if(Profit[i]==1)
    ScaleInPoints=(Close[i]-iBuyPrice[i])+100;
    if(Loss[i]==1)
    ScaleOutPoints=-(Close[i]-iBuyPrice[i])+50;
    if(Sell[i])
    {
    ScaleInPoints=100;
    ScaleOutPoints=50;
    }
}

Hello,

Thanks for reviewing this system! I will review the correction you suggested very soon. Can you also advise how did you set up Scale-In and Scale-out points using ATR? What was the logic used?

Thanks,
Snehil

hi Snehil,

my point is that you define at the start of the code:

BuyPrice=Open;
SellPrice=Open;
ShortPrice=Open;
CoverPrice=Open;

which is correct.

But then later you redefine the Buyprice as:

BuyPrice=ValueWhen(Buy,C);

this array you use to determine where to scale in or out which is correct but because you redefined the buyprice it will scale in and out at the price of the initial Buy defined by the MACD cross. When you look at the detailed backtest report you will see that the scalein and scaleout prices are not correct, they use the price of the initial buy.

I will send you my adjusted code to your private address tomorrow.

Still your code is interesting and I got all excited because it looks so professional and seemed to be working great. But in my opinion, because of the fact you redefine your BuyPrice array the scalein/out prices are incorrect.

Dear Ed sir,

Please post your adjusted code here it must useful to all

Thanks

hi,

i posted code here: http://wisestocktrader.com/indicatorpasties/1652-antimarti

made few changes also that you can see in the chart what the price is you pay when scaling in/out.

Dear ed sir,

Thanks a lot for posting

Thank you. I can see your modified code and it makes complete sense. I would update the same in my website too.

hi, one thing I did incorrectly is that the slippage applied will lead to a wrong scaleout price since these prices are stored in the buyprice array. So you will need to adjust this. So when slip = 0 it is correct in my opinion but if you add slippage you will need to adjust

so:

slip = TickSize * 2;
BuyPrice = Open + slip;
SellPrice = Open - slip;

would need to be rewritten as:

slip = TickSize * 2;
//BuyPrice = Open + slip;
BuyPrice = iif( Buy == 1 or Buy == sigscalein, Min( H, Open + slip ), iif( Buy == sigscaleout, Max( L, Open - slip ), 0 ) );
SellPrice = Max( L, Open - slip );

Hello Folks,

what i need to do to apply this code for short trade?

I am not getting any thing on the chart…….just getting blank chart when applied the formula……..I am using Amibroker 5.9

is wrong this code,empottasch clearify the problem; What do they want to prove? the correct code, and results as ever, is poor